[Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields…

components/autofill/core/common/password_form_fill_data.h

Index: components/autofill/core/common/password_form_fill_data.h
diff --git a/components/autofill/core/common/password_form_fill_data.h b/components/autofill/core/common/password_form_fill_data.h
index 14c4759865bc6d91492623af80af1b64bbfc6cf9..24ccc6788958554b8876b6578c40cd1511304d60 100644
--- a/components/autofill/core/common/password_form_fill_data.h
+++ b/components/autofill/core/common/password_form_fill_data.h
@@ -41,7 +41,17 @@ struct PasswordFormFillData {
 
   // Identifies the HTML form on the page and preferred username/password for
   // login.

[Ilya Sherman, 2014/11/04 23:05:31]

This comment seems obsolete.

[Pritam Nikam, 2014/11/05 05:58:15]

Done.

-  FormData basic_data;
+  // The name of the form.
+  base::string16 name;

[Ilya Sherman, 2014/11/04 23:05:31]

nit: Please leave blank lines between individual fields.

[Pritam Nikam, 2014/11/05 05:58:15]

Done.

+  // The URL (minus query parameters) containing the form.
+  GURL origin;
+  // The action target of the form.
+  GURL action;
+  // true if this form was submitted by a user gesture and not javascript.

[Ilya Sherman, 2014/11/04 23:05:31]

nit: "true" -> "True"

[Pritam Nikam, 2014/11/05 05:58:14]

Done.

+  bool user_submitted;
+
+  FormFieldData username_field;
+  FormFieldData password_field;

[Ilya Sherman, 2014/11/04 23:05:31]

Please document these fields.

[Pritam Nikam, 2014/11/05 05:58:15]

Done.

 
   // The signon realm of the preferred user/pass pair.
   std::string preferred_realm;