components/autofill/core/common/password_form_fill_data.cc - Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/password_form_fill_data.cc

Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed FormData from PasswordFormFillData. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/common/password_form_fill_data.h ('K') | « components/autofill/core/common/password_form_fill_data.h ('k') | components/password_manager/core/browser/password_autofill_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/password_form_fill_data.cc

diff --git a/components/autofill/core/common/password_form_fill_data.cc b/components/autofill/core/common/password_form_fill_data.cc

index ffc3db715c83893b416b88ac35599fccdd289f37..07c38ad0683adda1d67519e10526ef29d36a8011 100644

--- a/components/autofill/core/common/password_form_fill_data.cc

+++ b/components/autofill/core/common/password_form_fill_data.cc

@@ -47,11 +47,11 @@ void InitPasswordFormFillData(

password_field.form_control_type = "password";

// Fill basic form data.

- result->basic_data.name = form_on_page.form_data.name;

- result->basic_data.origin = form_on_page.origin;

- result->basic_data.action = form_on_page.action;

- result->basic_data.fields.push_back(username_field);

- result->basic_data.fields.push_back(password_field);

+ result->name = form_on_page.form_data.name;

+ result->origin = form_on_page.origin;

+ result->action = form_on_page.action;

+ result->username_field = username_field;

+ result->password_field = password_field;

result->wait_for_username = wait_for_username_before_autofill;

Ilya Sherman 2014/11/04 23:05:31 Where do you set the user_submitted value?

Pritam Nikam 2014/11/05 05:58:14 Done.

result->preferred_realm = preferred_match->original_signon_realm;