Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 613993002: Credential Manager: Reject credential request if an outstanding request is pending. (Closed)

Created:
6 years, 2 months ago by Mike West
Modified:
6 years, 2 months ago
Reviewers:
vabr (Chromium), palmer
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@yay
Project:
chromium
Visibility:
Public.

Description

Credential Manager: Reject credential request if an outstanding request is pending. If we're waiting on the PasswordStore (or the user, later) to give us credential data, don't pile on new requests. BUG=400674 Committed: https://crrev.com/4abf38fc383ad4a653233f6f6fb3ebd37b428c1c Cr-Commit-Position: refs/heads/master@{#297595}

Patch Set 1 #

Patch Set 2 : Rebase. #

Messages

Total messages: 11 (3 generated)
Mike West
Moar. WDYT? If you're happy, I'll find someone to stamp the IPC. -mike
6 years, 2 months ago (2014-09-30 09:39:20 UTC) #2
vabr (Chromium)
LGTM. The removed OVERRIDEs, that something Blink-specific, right? Cheers, Vaclav
6 years, 2 months ago (2014-09-30 10:30:42 UTC) #3
Mike West
Yes. We shouldn't OVERRIDE functions defined in the Blink repository, as it makes changes more ...
6 years, 2 months ago (2014-09-30 10:34:00 UTC) #4
Mike West
Chris, would you mind taking a quick look at this IPC change?
6 years, 2 months ago (2014-09-30 12:33:39 UTC) #6
palmer
lgtm
6 years, 2 months ago (2014-09-30 21:14:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613993002/20001
6 years, 2 months ago (2014-10-01 04:19:16 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 9870c1466e870cb9495a920f370901024068680d
6 years, 2 months ago (2014-10-01 04:23:07 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 04:24:11 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4abf38fc383ad4a653233f6f6fb3ebd37b428c1c
Cr-Commit-Position: refs/heads/master@{#297595}

Powered by Google App Engine
This is Rietveld 408576698