components/password_manager/content/renderer/credential_manager_client.h - Issue 613993002: Credential Manager: Reject credential request if an outstanding request is pending.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/renderer/credential_manager_client.h

Issue 613993002: Credential Manager: Reject credential request if an outstanding request is pending. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@yay

Patch Set: Rebase. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/common/credential_manager_messages.h ('k') | components/password_manager/content/renderer/credential_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/renderer/credential_manager_client.h

diff --git a/components/password_manager/content/renderer/credential_manager_client.h b/components/password_manager/content/renderer/credential_manager_client.h

index c8a642f399f2e9404f3412c461684cc7122c4fd8..04a2a90c9f8aa6a8bfc3fce12c9d275d2ba878af 100644

--- a/components/password_manager/content/renderer/credential_manager_client.h

+++ b/components/password_manager/content/renderer/credential_manager_client.h

@@ -59,19 +59,20 @@ class CredentialManagerClient : public blink::WebCredentialManagerClient,

virtual void OnAcknowledgeSignedOut(int request_id);

virtual void OnSendCredential(int request_id,

const CredentialInfo& credential_info);

+ virtual void OnRejectCredentialRequest(int request_id);

// blink::WebCredentialManager:

virtual void dispatchFailedSignIn(

const blink::WebCredential& credential,

- WebCredentialManagerClient::NotificationCallbacks* callbacks) OVERRIDE;

+ WebCredentialManagerClient::NotificationCallbacks* callbacks);

virtual void dispatchSignedIn(

const blink::WebCredential& credential,

- WebCredentialManagerClient::NotificationCallbacks* callbacks) OVERRIDE;

- virtual void dispatchSignedOut(NotificationCallbacks* callbacks) OVERRIDE;

+ WebCredentialManagerClient::NotificationCallbacks* callbacks);

+ virtual void dispatchSignedOut(NotificationCallbacks* callbacks);

virtual void dispatchRequest(

bool zero_click_only,

const blink::WebVector<blink::WebURL>& federations,

- RequestCallbacks* callbacks) OVERRIDE;

+ RequestCallbacks* callbacks);

private:

typedef IDMap<blink::WebCredentialManagerClient::RequestCallbacks,