Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: chrome/renderer/extensions/pepper_request_natives.cc

Issue 61383003: Pass pepper apps API calls through the existing js apps API bindings. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/pepper_request_natives.cc
diff --git a/chrome/renderer/extensions/pepper_request_natives.cc b/chrome/renderer/extensions/pepper_request_natives.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6bf884765f7c4d772f1b84d0318859c5757cb52c
--- /dev/null
+++ b/chrome/renderer/extensions/pepper_request_natives.cc
@@ -0,0 +1,50 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/renderer/extensions/pepper_request_natives.h"
+
+#include <string>
+
+#include "base/logging.h"
+#include "base/values.h"
+#include "chrome/renderer/extensions/chrome_v8_context.h"
+#include "content/public/renderer/v8_value_converter.h"
+
+namespace extensions {
+
+PepperRequestNatives::PepperRequestNatives(ChromeV8Context* context)
+ : ObjectBackedNativeHandler(context) {
+ RouteFunction(
+ "SendResponse",
+ base::Bind(&PepperRequestNatives::SendResponse, base::Unretained(this)));
+}
+
+void PepperRequestNatives::SendResponse(
+ const v8::FunctionCallbackInfo<v8::Value>& args) {
+ DCHECK_EQ(3, args.Length());
+ DCHECK(args[0]->IsInt32());
+ DCHECK(args[1]->IsArray());
+ int request_id = args[0]->Int32Value();
+ bool success = true;
+ std::string error;
+ if (args[2]->IsString()) {
+ error = *v8::String::Utf8Value(args[2]);
+ success = false;
+ }
+ scoped_ptr<content::V8ValueConverter> converter(
+ content::V8ValueConverter::create());
+ scoped_ptr<const base::Value> result(
+ converter->FromV8Value(args[1], context()->v8_context()));
+ if (!result) {
+ result.reset(new base::ListValue);
+ success = false;
not at google - send to devlin 2013/12/03 17:32:50 if success is false, could you set some kind of er
Sam McNally 2013/12/04 00:01:36 Done.
+ }
+ const base::ListValue* result_list = NULL;
+ if (!result->GetAsList(&result_list))
not at google - send to devlin 2013/12/03 17:32:50 avoid mysterious failures elsehere by making this
Sam McNally 2013/12/04 00:01:36 Done.
+ NOTREACHED();
+ context()->pepper_request_proxy()->OnResponseReceived(
+ request_id, success, *result_list, error);
+}
+
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698