Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: chrome/renderer/extensions/pepper_request_natives.cc

Issue 61383003: Pass pepper apps API calls through the existing js apps API bindings. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/renderer/extensions/pepper_request_natives.h"
6
7 #include <string>
8
9 #include "base/logging.h"
10 #include "base/values.h"
11 #include "chrome/renderer/extensions/chrome_v8_context.h"
12 #include "content/public/renderer/v8_value_converter.h"
13
14 namespace extensions {
15
16 PepperRequestNatives::PepperRequestNatives(ChromeV8Context* context)
17 : ObjectBackedNativeHandler(context) {
18 RouteFunction(
19 "SendResponse",
20 base::Bind(&PepperRequestNatives::SendResponse, base::Unretained(this)));
21 }
22
23 void PepperRequestNatives::SendResponse(
24 const v8::FunctionCallbackInfo<v8::Value>& args) {
25 DCHECK_EQ(3, args.Length());
26 DCHECK(args[0]->IsInt32());
27 DCHECK(args[1]->IsArray());
28 int request_id = args[0]->Int32Value();
29 bool success = true;
30 std::string error;
31 if (args[2]->IsString()) {
32 error = *v8::String::Utf8Value(args[2]);
33 success = false;
34 }
35 scoped_ptr<content::V8ValueConverter> converter(
36 content::V8ValueConverter::create());
37 scoped_ptr<const base::Value> result(
38 converter->FromV8Value(args[1], context()->v8_context()));
39 if (!result) {
40 result.reset(new base::ListValue);
41 success = false;
not at google - send to devlin 2013/12/03 17:32:50 if success is false, could you set some kind of er
Sam McNally 2013/12/04 00:01:36 Done.
42 }
43 const base::ListValue* result_list = NULL;
44 if (!result->GetAsList(&result_list))
not at google - send to devlin 2013/12/03 17:32:50 avoid mysterious failures elsehere by making this
Sam McNally 2013/12/04 00:01:36 Done.
45 NOTREACHED();
46 context()->pepper_request_proxy()->OnResponseReceived(
47 request_id, success, *result_list, error);
48 }
49
50 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698