Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 613673003: [Mac] On Mavericks or later, use NSWorkspace to open download items. (Closed)

Created:
6 years, 2 months ago by Robert Sesek
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mac] On Mavericks or later, use NSWorkspace to open download items. With the NSWorkspaceLaunchWithErrorPresentation option, Finder no longer silently fails opening the file. BUG=32921 R=avi@chromium.org TEST=Download a DMG file. Click the download shelf button to open/mount it. Finder activates the new disk image window as the topmost. TEST=Download a file with an unassociated file extension type (e.g. "test.foobar"). Click the download shelf button to open it. Finder presents the unknown file type dialog. Committed: https://chromium.googlesource.com/chromium/src/+/b83907e0384a25d8d10e5e15c564db4ec18f21bc

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comment #

Patch Set 3 : Fix bad upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -7 lines) Patch
M base/mac/sdk_forward_declarations.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/platform_util_mac.mm View 1 2 2 chunks +25 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Robert Sesek
6 years, 2 months ago (2014-09-29 15:28:55 UTC) #1
Avi (use Gerrit)
https://codereview.chromium.org/613673003/diff/1/chrome/browser/platform_util_mac.mm File chrome/browser/platform_util_mac.mm (right): https://codereview.chromium.org/613673003/diff/1/chrome/browser/platform_util_mac.mm#newcode43 chrome/browser/platform_util_mac.mm:43: if (base::mac::IsOSMavericksOrLater()) { Fix the comment at the top ...
6 years, 2 months ago (2014-09-29 15:36:00 UTC) #2
Robert Sesek
https://codereview.chromium.org/613673003/diff/1/chrome/browser/platform_util_mac.mm File chrome/browser/platform_util_mac.mm (right): https://codereview.chromium.org/613673003/diff/1/chrome/browser/platform_util_mac.mm#newcode43 chrome/browser/platform_util_mac.mm:43: if (base::mac::IsOSMavericksOrLater()) { On 2014/09/29 15:36:00, Avi wrote: > ...
6 years, 2 months ago (2014-09-29 15:41:16 UTC) #3
Avi (use Gerrit)
LGTM!
6 years, 2 months ago (2014-09-29 15:48:38 UTC) #4
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/b83907e0384a25d8d10e5e15c564db4ec18f21bc Cr-Commit-Position: refs/heads/master@{#297239}
6 years, 2 months ago (2014-09-29 19:48:03 UTC) #5
Robert Sesek
6 years, 2 months ago (2014-09-29 19:48:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as b83907e.

Powered by Google App Engine
This is Rietveld 408576698