[Mac] On Mavericks or later, use NSWorkspace to open download items.

chrome/browser/platform_util_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/platform_util.h"
 
 #include <Carbon/Carbon.h>
 #import <Cocoa/Cocoa.h>
 #include <CoreServices/CoreServices.h>
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/mac/mac_logging.h"
+#import "base/mac/mac_util.h"
+#import "base/mac/sdk_forward_declarations.h"
 #include "base/mac/scoped_aedesc.h"
 #include "base/strings/sys_string_conversions.h"
 #include "url/gurl.h"
 
 namespace platform_util {
 
 void ShowItemInFolder(Profile* profile, const base::FilePath& full_path) {
   DCHECK([NSThread isMainThread]);
   NSString* path_string = base::SysUTF8ToNSString(full_path.value());
   if (!path_string || ![[NSWorkspace sharedWorkspace] selectFile:path_string
                                         inFileViewerRootedAtPath:nil])
     LOG(WARNING) << "NSWorkspace failed to select file " << full_path.value();
 }
 
 // This function opens a file.  This doesn't use LaunchServices or NSWorkspace
 // because of two bugs:
 //  1. Incorrect app activation with com.apple.quarantine:
 //     http://crbug.com/32921
 //  2. Silent no-op for unassociated file types: http://crbug.com/50263
 // Instead, an AppleEvent is constructed to tell the Finder to open the
 // document.
 void OpenItem(Profile* profile, const base::FilePath& full_path) {
   DCHECK([NSThread isMainThread]);
   NSString* path_string = base::SysUTF8ToNSString(full_path.value());
   if (!path_string)
     return;
 
+  if (base::mac::IsOSMavericksOrLater()) {

[Avi (use Gerrit), 2014/09/29 15:36:00]

Fix the comment at the top of the function ("This function opens a file...") or
move that function to below here.

[Robert Sesek, 2014/09/29 15:41:16]

Done.

+    NSURL* url = [NSURL fileURLWithPath:path_string];
+    if (!url)
+      return;
+
+    const NSWorkspaceLaunchOptions launch_options =
+        NSWorkspaceLaunchAsync | NSWorkspaceLaunchWithErrorPresentation;
+    [[NSWorkspace sharedWorkspace] openURLs:@[ url ]
+                    withAppBundleIdentifier:nil
+                                    options:launch_options
+             additionalEventParamDescriptor:nil
+                          launchIdentifiers:NULL]) {
+    return;
+  }
+
   // Create the target of this AppleEvent, the Finder.
   base::mac::ScopedAEDesc<AEAddressDesc> address;
   const OSType finderCreatorCode = 'MACS';
   OSErr status = AECreateDesc(typeApplSignature,  // type
                               &finderCreatorCode,  // data
                               sizeof(finderCreatorCode),  // dataSize
                               address.OutPointer());  // result
   if (status != noErr) {
     OSSTATUS_LOG(WARNING, status) << "Could not create OpenItem() AE target";
     return;
@@ skipping 100 matching lines @@
           [[view window] isVisible]);
 }
 
 bool IsSwipeTrackingFromScrollEventsEnabled() {
   SEL selector = @selector(isSwipeTrackingFromScrollEventsEnabled);
   return [NSEvent respondsToSelector:selector]
       && [NSEvent performSelector:selector];
 }
 
 }  // namespace platform_util