Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 613503002: Move paint code for RenderScrollbar and RenderScrollbarPart into ScrollbarPainter. (Closed)

Created:
6 years, 2 months ago by chrishtr
Modified:
6 years, 2 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, slimming-paint-reviews_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Move paint code for RenderScrollbar and RenderScrollbarPart into ScrollbarPainter. In so doing, exposed a new getPart() method on RenderScrollbar to get the part. Also, this patch changes the code in RenderScrollbarPart to explicitly call the BlockPainter::paint method, rather than relying on virtual function calls. This is possible because RenderScrollbarPart is a FINAL class that inherits from BlockPainter. Therefore all of these calls must be the BlockPainter version. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182855

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -41 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 2 chunks +2 lines, -1 line 0 comments Download
A Source/core/paint/ScrollbarPainter.h View 1 chunk +33 lines, -0 lines 0 comments Download
A Source/core/paint/ScrollbarPainter.cpp View 1 chunk +45 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderScrollbar.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderScrollbar.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderScrollbarPart.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderScrollbarPart.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M Source/core/rendering/RenderScrollbarTheme.cpp View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
chrishtr
6 years, 2 months ago (2014-09-27 00:34:24 UTC) #2
pdr.
On 2014/09/27 00:34:24, chrishtr wrote: LGTM. Sadness about that layering violation :(
6 years, 2 months ago (2014-09-29 17:34:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613503002/1
6 years, 2 months ago (2014-09-29 17:34:56 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 17:38:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182855

Powered by Google App Engine
This is Rietveld 408576698