Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1936)

Unified Diff: base/logging.cc

Issue 613273005: Enable "extern template" under MSVC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/logging.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/logging.cc
diff --git a/base/logging.cc b/base/logging.cc
index 6593d2ce7b915fd4b978eafef6a1ba84a56002e3..150a40815c51c8ee2cf48668caa245d86369afba 100644
--- a/base/logging.cc
+++ b/base/logging.cc
@@ -444,8 +444,6 @@ LogMessageHandlerFunction GetLogMessageHandler() {
return log_message_handler;
}
-// MSVC doesn't like complex extern templates and DLLs.
-#if !defined(COMPILER_MSVC)
// Explicit instantiations for commonly used comparisons.
template std::string* MakeCheckOpString<int, int>(
const int&, const int&, const char* names);
@@ -457,7 +455,6 @@ template std::string* MakeCheckOpString<unsigned int, unsigned long>(
const unsigned int&, const unsigned long&, const char* names);
template std::string* MakeCheckOpString<std::string, std::string>(
const std::string&, const std::string&, const char* name);
-#endif
#if !defined(NDEBUG)
// Displays a message box to the user with the error message in it.
« no previous file with comments | « base/logging.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698