Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Unified Diff: base/logging.h

Issue 613273005: Enable "extern template" under MSVC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/logging.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/logging.h
diff --git a/base/logging.h b/base/logging.h
index 4661f0f257ec5a0eaa939f5921877f56eb8dc63d..926e36dfaa0ce007bfe481c01247d77fbfdd76bd 100644
--- a/base/logging.h
+++ b/base/logging.h
@@ -483,8 +483,6 @@ std::string* MakeCheckOpString(const t1& v1, const t2& v2, const char* names) {
return msg;
}
-// MSVC doesn't like complex extern templates and DLLs.
-#if !defined(COMPILER_MSVC)
// Commonly used instantiations of MakeCheckOpString<>. Explicitly instantiated
// in logging.cc.
extern template BASE_EXPORT std::string* MakeCheckOpString<int, int>(
@@ -501,7 +499,6 @@ std::string* MakeCheckOpString<unsigned int, unsigned long>(
extern template BASE_EXPORT
std::string* MakeCheckOpString<std::string, std::string>(
const std::string&, const std::string&, const char* name);
-#endif
// Helper functions for CHECK_OP macro.
// The (int, int) specialization works around the issue that the compiler
« no previous file with comments | « no previous file | base/logging.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698