Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 613273005: Enable "extern template" under MSVC (Closed)

Created:
6 years, 2 months ago by mdempsky
Modified:
6 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable "extern template" under MSVC Committed: https://crrev.com/e63894efb393886a2430cde354ed7b5dd06283e1 Cr-Commit-Position: refs/heads/master@{#297955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M base/logging.h View 2 chunks +0 lines, -3 lines 0 comments Download
M base/logging.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
lgtm if the cq likes it
6 years, 2 months ago (2014-10-02 22:26:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/613273005/1
6 years, 2 months ago (2014-10-02 22:30:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as d2ad0a6e7ecc274016fecbd31a81f836b28a33c3
6 years, 2 months ago (2014-10-03 00:03:37 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 00:07:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e63894efb393886a2430cde354ed7b5dd06283e1
Cr-Commit-Position: refs/heads/master@{#297955}

Powered by Google App Engine
This is Rietveld 408576698