Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: chrome/browser/extensions/extension_info_map.h

Issue 61323002: Fix broken threading model in CheckDesktopNotificationPermission (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/extensions/extension_info_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_info_map.h
diff --git a/chrome/browser/extensions/extension_info_map.h b/chrome/browser/extensions/extension_info_map.h
index 53c04f597b9e036d1e1ab787ca674fa20560c55b..c0e91cd6a60499a4ea4eed6d4b4c6ba17106b81c 100644
--- a/chrome/browser/extensions/extension_info_map.h
+++ b/chrome/browser/extensions/extension_info_map.h
@@ -36,7 +36,8 @@ class ExtensionInfoMap : public base::RefCountedThreadSafe<ExtensionInfoMap> {
// Callback for when new extensions are loaded.
void AddExtension(const extensions::Extension* extension,
base::Time install_time,
- bool incognito_enabled);
+ bool incognito_enabled,
+ bool notifications_disabled);
// Callback for when an extension is unloaded.
void RemoveExtension(const std::string& extension_id,
@@ -85,6 +86,12 @@ class ExtensionInfoMap : public base::RefCountedThreadSafe<ExtensionInfoMap> {
void SetSigninProcess(int process_id);
bool IsSigninProcess(int process_id) const;
+ // Notifications can be enabled/disabled in real time by the user.
+ void SetNotificationsDisabled(const std::string& extension_id,
+ bool notifications_disabled);
+ bool GetNotificationsDisabledForExtension(const std::string& extension_id)
Matt Perry 2013/11/06 00:57:18 nit: bool functions should read like a question: "
dewittj 2013/11/06 19:20:36 Done.
+ const;
+
private:
friend class base::RefCountedThreadSafe<ExtensionInfoMap>;
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/extensions/extension_info_map.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698