Fix broken threading model in CheckDesktopNotificationPermission

chrome/browser/extensions/extension_info_map.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_INFO_MAP_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_INFO_MAP_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 18 matching lines @@
   const ExtensionSet& extensions() const { return extensions_; }
   const ExtensionSet& disabled_extensions() const {
     return disabled_extensions_;
   }
 
   const extensions::ProcessMap& process_map() const;
 
   // Callback for when new extensions are loaded.
   void AddExtension(const extensions::Extension* extension,
                     base::Time install_time,
-                    bool incognito_enabled);
+                    bool incognito_enabled,
+                    bool notifications_disabled);
 
   // Callback for when an extension is unloaded.
   void RemoveExtension(const std::string& extension_id,
                        const extensions::UnloadedExtensionInfo::Reason reason);
 
   // Returns the time the extension was installed, or base::Time() if not found.
   base::Time GetInstallTime(const std::string& extension_id) const;
 
   // Returns true if the user has allowed this extension to run in incognito
   // mode.
@@ skipping 28 matching lines @@
       const GURL& origin, int process_id,
       extensions::APIPermission::ID permission) const;
 
   ExtensionsQuotaService* GetQuotaService();
 
   // Keep track of the signin process, so we can restrict extension access to
   // it.
   void SetSigninProcess(int process_id);
   bool IsSigninProcess(int process_id) const;
 
+  // Notifications can be enabled/disabled in real time by the user.
+  void SetNotificationsDisabled(const std::string& extension_id,
+                               bool notifications_disabled);
+  bool GetNotificationsDisabledForExtension(const std::string& extension_id)

[Matt Perry, 2013/11/06 00:57:18]

nit: bool functions should read like a question: "AreNotificationsDisabled".

[dewittj, 2013/11/06 19:20:36]

Done.

+      const;
+
  private:
   friend class base::RefCountedThreadSafe<ExtensionInfoMap>;
 
   // Extra dynamic data related to an extension.
   struct ExtraData;
   // Map of extension_id to ExtraData.
   typedef std::map<std::string, ExtraData> ExtraDataMap;
 
   ~ExtensionInfoMap();
 
   ExtensionSet extensions_;
   ExtensionSet disabled_extensions_;
 
   // Extra data associated with enabled extensions.
   ExtraDataMap extra_data_;
 
   // Used by dispatchers to limit API quota for individual extensions.
   // The ExtensionQutoaService is not thread safe. We need to create and destroy
   // it on the IO thread.
   scoped_ptr<ExtensionsQuotaService> quota_service_;
 
   // Assignment of extensions to processes.
   extensions::ProcessMap process_map_;
 
   int signin_process_id_;
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_INFO_MAP_H_