[chromedriver] setting browser default download directory

chrome/test/chromedriver/client/chromedriver.py

Index: chrome/test/chromedriver/client/chromedriver.py
diff --git a/chrome/test/chromedriver/client/chromedriver.py b/chrome/test/chromedriver/client/chromedriver.py
index fb1aa2b27fded702a22419ca0273bc43a79de2d2..1fba2615f2ed70e9ecf9d21caea137e1d665ba23 100644
--- a/chrome/test/chromedriver/client/chromedriver.py
+++ b/chrome/test/chromedriver/client/chromedriver.py
@@ -60,7 +60,8 @@ def _ExceptionForResponse(response):
 class ChromeDriver(object):
   """Starts and controls a single Chrome instance on this machine."""
 
-  def __init__(self, server_url, chrome_binary=None, android_package=None,
+  def __init__(self, server_url, download_dir=None, chrome_binary=None,
+               android_package=None,

[samuong, 2014/10/16 20:23:40]

Reflow lines 63-70, or move download_dir to the end of the argument list.

                android_activity=None, android_process=None,
                android_use_running_app=None, chrome_switches=None,
                chrome_extensions=None, chrome_log_path=None,
@@ -115,6 +116,14 @@ class ChromeDriver(object):
       assert performance_log_level in log_levels
       logging_prefs['performance'] = performance_log_level
 
+    download_prefs = {}
+    if (download_dir):
+      default_dir = {}
+      default_dir['directory_upgrade'] =  'true'

[samuong, 2014/10/16 20:23:40]

Does it work if you don't set directory_upgrade to true?

[andrewcheng, 2014/10/17 22:59:52]

   you have  comment in other place - we may not need this.
 I removed it now.

+      default_dir['default_directory'] = download_dir
+      download_prefs['download'] =  default_dir
+      options['prefs'] =  download_prefs
+
     params = {
       'desiredCapabilities': {
         'chromeOptions': options,