[chromedriver] setting browser default download directory

chrome/test/chromedriver/client/chromedriver.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import command_executor
 from command_executor import Command
 from webelement import WebElement
 
 
 class ChromeDriverException(Exception):
@@ skipping 42 matching lines @@
     33: SessionNotCreatedException
   }
   status = response['status']
   msg = response['value']['message']
   return exception_class_map.get(status, ChromeDriverException)(msg)
 
 
 class ChromeDriver(object):
   """Starts and controls a single Chrome instance on this machine."""
 
-  def __init__(self, server_url, chrome_binary=None, android_package=None,
+  def __init__(self, server_url, download_dir=None, chrome_binary=None,
+               android_package=None,

[samuong, 2014/10/16 20:23:40]

Reflow lines 63-70, or move download_dir to the end of the argument list.

                android_activity=None, android_process=None,
                android_use_running_app=None, chrome_switches=None,
                chrome_extensions=None, chrome_log_path=None,
                debugger_address=None, browser_log_level=None,
                performance_log_level=None, mobile_emulation=None,
                experimental_options=None):
     self._executor = command_executor.CommandExecutor(server_url)
 
     options = {}
 
@@ skipping 34 matching lines @@
 
     logging_prefs = {}
     log_levels = ['ALL', 'DEBUG', 'INFO', 'WARNING', 'SEVERE', 'OFF']
     if browser_log_level:
       assert browser_log_level in log_levels
       logging_prefs['browser'] = browser_log_level
     if performance_log_level:
       assert performance_log_level in log_levels
       logging_prefs['performance'] = performance_log_level
 
+    download_prefs = {}
+    if (download_dir):
+      default_dir = {}
+      default_dir['directory_upgrade'] =  'true'

[samuong, 2014/10/16 20:23:40]

Does it work if you don't set directory_upgrade to true?

[andrewcheng, 2014/10/17 22:59:52]

   you have  comment in other place - we may not need this.
 I removed it now.

+      default_dir['default_directory'] = download_dir
+      download_prefs['download'] =  default_dir
+      options['prefs'] =  download_prefs
+
     params = {
       'desiredCapabilities': {
         'chromeOptions': options,
         'loggingPrefs': logging_prefs
       }
     }
 
     response = self._ExecuteCommand(Command.NEW_SESSION, params)
     self._session_id = response['sessionId']
     self.capabilities = self._UnwrapValue(response['value'])
@@ skipping 211 matching lines @@
     return self.ExecuteCommand(Command.GET_LOG, {'type': type})
 
   def GetAvailableLogTypes(self):
     return self.ExecuteCommand(Command.GET_AVAILABLE_LOG_TYPES)
 
   def IsAutoReporting(self):
     return self.ExecuteCommand(Command.IS_AUTO_REPORTING)
 
   def SetAutoReporting(self, enabled):
     self.ExecuteCommand(Command.SET_AUTO_REPORTING, {'enabled': enabled})