Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 61293005: ninja: use clang by default on Mac, matching recent Xcodes (Closed)

Created:
7 years, 1 month ago by Mark Mentovai
Modified:
7 years, 1 month ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja: use cc and c++ instead of gcc and g++ by default on non-Windows. See https://groups.google.com/forum/#!topic/gyp-developer/50IkuJBVGbU . For Mac specifically: g++ on my system is not Xcode's g++, but proper FSF GNU GCC g++. This doesn't hurt Chromium, which sets clang as the compiler by default, but does hurt projects that don't explicitly specify a compiler, including the tests. FSF GNU GCC g++ doesn't understand these options that xcode_emulation.py adds: g++: error: unrecognized command line option ‘-fasm-blocks’ g++: error: unrecognized command line option ‘-mpascal-strings’ R=thakis@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1791

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M pylib/gyp/generator/ninja.py View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M test/mac/gyptest-xcode-gcc.py View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M test/mac/xcode-gcc/test.gyp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark Mentovai
7 years, 1 month ago (2013-11-15 18:49:01 UTC) #1
Nico
Sure, why not. lgtm. (I build my FSF gcc with --program-suffix=-4.8, so that "gcc" gives ...
7 years, 1 month ago (2013-11-17 05:11:46 UTC) #2
Nico
Actually! I just remembered the thread "Should the ninja generator default to cc instead of ...
7 years, 1 month ago (2013-11-17 10:11:39 UTC) #3
Mark Mentovai
That works for me. (Actually, FSF GNU GCC’s “make install” will give you its own ...
7 years, 1 month ago (2013-11-17 15:21:29 UTC) #4
Mark Mentovai
7 years, 1 month ago (2013-11-18 15:00:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r1791 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698