Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: test/mac/gyptest-xcode-gcc.py

Issue 61293005: ninja: use clang by default on Mac, matching recent Xcodes (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | test/mac/xcode-gcc/test.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mac/gyptest-xcode-gcc.py
===================================================================
--- test/mac/gyptest-xcode-gcc.py (revision 1785)
+++ test/mac/gyptest-xcode-gcc.py (working copy)
@@ -31,9 +31,10 @@
# clang doesn't warn on invalid offsetofs, it silently ignores
# -Wno-invalid-offsetof.
# TODO(thakis): This isn't really the right way to detect the compiler,
- # `which cc` detects what make ends up using, and Xcode has some embedded
- # compiler, but it's a reliable proxy at least on the bots.
- if os.readlink('/usr/bin/cc') != 'clang':
+ # Xcode has some embedded compiler, but it's a reliable proxy at least on
+ # the bots. The compiler is forced to gcc/g++ in the gyp file in a
+ # make_global_settings section for ninja and make.
+ if test.format != 'xcode' or os.readlink('/usr/bin/cc') != 'clang':
targets.append('warn_about_invalid_offsetof_macro')
for target in targets:
« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | test/mac/xcode-gcc/test.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698