Chromium Code Reviews Chromium Code Reviews
Issue
61273002:
Update mach_override to upstream 1a1bb352 (Closed)
DescriptionUpdate mach_override to upstream 1a1bb352
CFLog, which is overridden by content/renderer/renderer_main_platform_delegate_mac.mm, contains the following instruction in 64-bit form on 10.6.8 and 10.7.5:
4881ECD0000000 sub rsp, 0xd0
mach_override’s puny simplistic fake disassembler didn’t understand this instruction. This resulted in mach_override failing, which triggered a CHECK failure during renderer startup, with the result that everything would be a sad tab on 10.6 and 10.7 64-bit.
The latest version of mach_override replaces its weak old non-disassembler with libudis86, which should be much more capable in the area of understanding instructions, and which should improve mach_override’s ability to patch code without always having to retrain it.
In the mean time, the upstream change that was probably causing us to be unable to update to the current HEAD (https://github.com/rentzsch/mach_star/commit/498e0ba3)
has been backed out since then (https://github.com/rentzsch/mach_override/commit/1b3aa46f), so it should now be safe to update to HEAD.
Local patches https://codereview.chromium.org/21208002/ and https://codereview.chromium.org/22798004/ have been reapplied with minor fixes to work with the current version.
BUG=315218
R=avi@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233175
Patch Set 1 #
Total comments: 1
Patch Set 2 : Reapply local patches #Patch Set 3 : #
Total comments: 1
Messages
Total messages: 6 (0 generated)
|
