Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 60293005: Relax checklicenses.py for third_party/mach_override (Closed)

Created:
7 years, 1 month ago by Mark Mentovai
Modified:
7 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Update licensecheck.pl for third_party/mach_override as of r233175. BUG=315397 R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233200

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Modify licensecheck.pl instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/devscripts/licensecheck.pl View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Mark Mentovai
7 years, 1 month ago (2013-11-06 02:27:05 UTC) #1
Lei Zhang
Would you mind going to third_party/devscripts/licensecheck.py line ~488 and make it match the new license ...
7 years, 1 month ago (2013-11-06 02:31:15 UTC) #2
Lei Zhang
Err, licensecheck.pl. Hope your Perl is not too rusty.
7 years, 1 month ago (2013-11-06 02:31:32 UTC) #3
Mark Mentovai
Like this? The old URL still might be used elsewhere in the source tree (according ...
7 years, 1 month ago (2013-11-06 02:42:33 UTC) #4
Lei Zhang
On 2013/11/06 02:42:33, Mark Mentovai wrote: > Like this? > > The old URL still ...
7 years, 1 month ago (2013-11-06 02:46:01 UTC) #5
Mark Mentovai
7 years, 1 month ago (2013-11-06 02:52:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r233200 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698