Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 612653002: Fix reading and writing format 13 cmap tables (Closed)

Created:
6 years, 2 months ago by devongovett
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/external/ots.git@master
Visibility:
Public.

Description

Fix reading and writing format 13 cmap tables * language is a 32-bit field when reading * fix table length calculation when writing See https://cloudup.com/cl1gWiyp7gS to download an example font that fails sanitization before this change, but passes afterward. R=yusukes@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/cmap.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
devongovett
Bump.
6 years, 2 months ago (2014-10-13 01:05:28 UTC) #3
behdad_google
lgtm Note that these are fixed in the github fork already. We should switch Chrome ...
6 years, 2 months ago (2014-10-13 23:31:19 UTC) #5
Kunihiko Sakamoto
6 years, 2 months ago (2014-10-16 08:01:03 UTC) #6
lgtm

Thanks. Committed as r117.
https://code.google.com/p/ots/source/detail?r=117

Powered by Google App Engine
This is Rietveld 408576698