Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 612323013: QUIC - (no behavior change) s/NULL/nullptr/g in .../quic/... (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)
Modified:
6 years, 2 months ago
Reviewers:
rjshade, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng, agl, wtc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

QUIC - (no behavior change) s/NULL/nullptr/g in .../quic/... C++11 in Chromium! http://g/quic-dev/iBPFBDwPMjQ Merge internal change: 76451118 R=rch@chromium.org, rjshade@chromium.org Committed: https://crrev.com/be6357371938cb811880766c94768e534023db29 Cr-Commit-Position: refs/heads/master@{#297937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1126 lines, -1129 lines) Patch
M net/quic/congestion_control/loss_detection_interface.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/receive_algorithm_interface.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_simulator.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/send_algorithm_simulator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/congestion_control/tcp_loss_algorithm_test.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M net/quic/congestion_control/time_loss_algorithm_test.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M net/quic/crypto/aead_base_decrypter_nss.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/crypto/aead_base_decrypter_openssl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/crypto/aead_base_encrypter_nss.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/crypto/aead_base_encrypter_openssl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/crypto/aes_128_gcm_12_decrypter_nss.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/crypto/aes_128_gcm_12_decrypter_test.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M net/quic/crypto/aes_128_gcm_12_encrypter_nss.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/crypto/aes_128_gcm_12_encrypter_test.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M net/quic/crypto/cert_compressor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/crypto/cert_compressor_test.cc View 6 chunks +17 lines, -17 lines 0 comments Download
M net/quic/crypto/chacha20_poly1305_decrypter_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/chacha20_poly1305_decrypter_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/crypto/chacha20_poly1305_encrypter_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/chacha20_poly1305_encrypter_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/crypto/channel_id.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/channel_id_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/channel_id_openssl.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M net/quic/crypto/channel_id_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/crypto/crypto_framer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/crypto/crypto_framer.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M net/quic/crypto/crypto_framer_test.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M net/quic/crypto/crypto_handshake_message.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/crypto_server_test.cc View 14 chunks +14 lines, -14 lines 0 comments Download
M net/quic/crypto/crypto_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/crypto/crypto_utils_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/crypto/curve25519_key_exchange.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/curve25519_key_exchange.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/null_decrypter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/crypto/p256_key_exchange.h View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/crypto/p256_key_exchange_nss.cc View 6 chunks +10 lines, -11 lines 0 comments Download
M net/quic/crypto/p256_key_exchange_openssl.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M net/quic/crypto/p256_key_exchange_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/crypto/proof_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/proof_verifier.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_client_config.h View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 3 chunks +5 lines, -5 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 28 chunks +39 lines, -36 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config_test.cc View 13 chunks +53 lines, -54 lines 0 comments Download
M net/quic/crypto/quic_decrypter.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/quic_decrypter.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/quic_encrypter.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/quic_encrypter.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/scoped_evp_aead_ctx.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/crypto/strike_register.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/iovector_test.cc View 9 chunks +14 lines, -14 lines 0 comments Download
M net/quic/quic_ack_notifier_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_client_session.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M net/quic/quic_client_session_test.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_config.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M net/quic/quic_connection.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_connection.cc View 36 chunks +42 lines, -41 lines 0 comments Download
M net/quic/quic_connection_test.cc View 77 chunks +127 lines, -124 lines 0 comments Download
M net/quic/quic_crypto_client_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 8 chunks +17 lines, -18 lines 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_crypto_server_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 7 chunks +10 lines, -13 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M net/quic/quic_crypto_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_data_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_data_stream_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_data_writer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/quic_data_writer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_dispatcher.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M net/quic/quic_end_to_end_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_framer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/quic_framer.cc View 21 chunks +33 lines, -33 lines 0 comments Download
M net/quic/quic_framer_test.cc View 36 chunks +37 lines, -37 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_http_stream.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M net/quic/quic_in_memory_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_in_memory_cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 27 chunks +31 lines, -31 lines 0 comments Download
M net/quic/quic_packet_creator.h View 3 chunks +6 lines, -6 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 11 chunks +18 lines, -17 lines 0 comments Download
M net/quic/quic_packet_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_packet_generator.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 30 chunks +51 lines, -55 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_protocol.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M net/quic/quic_reliable_client_stream.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 19 chunks +25 lines, -23 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 21 chunks +29 lines, -30 lines 0 comments Download
M net/quic/quic_server_session.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_session.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M net/quic/quic_session_test.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_spdy_server_stream.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 37 chunks +47 lines, -47 lines 0 comments Download
M net/quic/quic_time_wait_list_manager.h View 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/quic_unacked_packet_map.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 11 chunks +32 lines, -35 lines 0 comments Download
M net/quic/quic_unacked_packet_map_test.cc View 5 chunks +21 lines, -21 lines 0 comments Download
M net/quic/quic_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_utils_chromium_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/reliable_quic_stream.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 11 chunks +14 lines, -14 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.h View 3 chunks +4 lines, -3 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 6 chunks +8 lines, -10 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils_chromium.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils_openssl.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream_factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M net/tools/quic/quic_client.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M net/tools/quic/quic_client_session.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_in_memory_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_in_memory_cache_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server_session.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_socket_utils.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream_test.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.h View 1 chunk +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 16 chunks +20 lines, -20 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.cc View 4 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
ramant (doing other things)
6 years, 2 months ago (2014-10-02 19:58:58 UTC) #1
ramant (doing other things)
Hi Ryan and Robbie, I have made changes to chromium specific files. Would like to ...
6 years, 2 months ago (2014-10-02 20:01:46 UTC) #2
Ryan Hamilton
lgtm!
6 years, 2 months ago (2014-10-02 20:03:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612323013/1
6 years, 2 months ago (2014-10-02 21:43:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as f2e6d431ea884408200dbbf1bce4947342c2020f
6 years, 2 months ago (2014-10-02 22:51:52 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 22:52:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be6357371938cb811880766c94768e534023db29
Cr-Commit-Position: refs/heads/master@{#297937}

Powered by Google App Engine
This is Rietveld 408576698