Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: net/quic/quic_reliable_client_stream.cc

Issue 612323013: QUIC - (no behavior change) s/NULL/nullptr/g in .../quic/... (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_protocol.cc ('k') | net/quic/quic_sent_packet_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_reliable_client_stream.h" 5 #include "net/quic/quic_reliable_client_stream.h"
6 6
7 #include "base/callback_helpers.h" 7 #include "base/callback_helpers.h"
8 #include "net/base/net_errors.h" 8 #include "net/base/net_errors.h"
9 #include "net/quic/quic_session.h" 9 #include "net/quic/quic_session.h"
10 #include "net/quic/quic_write_blocked_list.h" 10 #include "net/quic/quic_write_blocked_list.h"
11 11
12 namespace net { 12 namespace net {
13 13
14 QuicReliableClientStream::QuicReliableClientStream(QuicStreamId id, 14 QuicReliableClientStream::QuicReliableClientStream(QuicStreamId id,
15 QuicSession* session, 15 QuicSession* session,
16 const BoundNetLog& net_log) 16 const BoundNetLog& net_log)
17 : QuicDataStream(id, session), 17 : QuicDataStream(id, session),
18 net_log_(net_log), 18 net_log_(net_log),
19 delegate_(NULL) { 19 delegate_(nullptr) {
20 } 20 }
21 21
22 QuicReliableClientStream::~QuicReliableClientStream() { 22 QuicReliableClientStream::~QuicReliableClientStream() {
23 if (delegate_) 23 if (delegate_)
24 delegate_->OnClose(connection_error()); 24 delegate_->OnClose(connection_error());
25 } 25 }
26 26
27 uint32 QuicReliableClientStream::ProcessData(const char* data, 27 uint32 QuicReliableClientStream::ProcessData(const char* data,
28 uint32 data_len) { 28 uint32 data_len) {
29 // TODO(rch): buffer data if we don't have a delegate. 29 // TODO(rch): buffer data if we don't have a delegate.
30 if (!delegate_) { 30 if (!delegate_) {
31 DLOG(ERROR) << "Missing delegate"; 31 DLOG(ERROR) << "Missing delegate";
32 Reset(QUIC_STREAM_CANCELLED); 32 Reset(QUIC_STREAM_CANCELLED);
33 return 0; 33 return 0;
34 } 34 }
35 35
36 int rv = delegate_->OnDataReceived(data, data_len); 36 int rv = delegate_->OnDataReceived(data, data_len);
37 if (rv != OK) { 37 if (rv != OK) {
38 DLOG(ERROR) << "Delegate refused data, rv: " << rv; 38 DLOG(ERROR) << "Delegate refused data, rv: " << rv;
39 Reset(QUIC_BAD_APPLICATION_PAYLOAD); 39 Reset(QUIC_BAD_APPLICATION_PAYLOAD);
40 return 0; 40 return 0;
41 } 41 }
42 return data_len; 42 return data_len;
43 } 43 }
44 44
45 void QuicReliableClientStream::OnFinRead() { 45 void QuicReliableClientStream::OnFinRead() {
46 if (delegate_) { 46 if (delegate_) {
47 delegate_->OnClose(connection_error()); 47 delegate_->OnClose(connection_error());
48 delegate_ = NULL; 48 delegate_ = nullptr;
49 } 49 }
50 ReliableQuicStream::OnFinRead(); 50 ReliableQuicStream::OnFinRead();
51 } 51 }
52 52
53 void QuicReliableClientStream::OnCanWrite() { 53 void QuicReliableClientStream::OnCanWrite() {
54 ReliableQuicStream::OnCanWrite(); 54 ReliableQuicStream::OnCanWrite();
55 55
56 if (!HasBufferedData() && !callback_.is_null()) { 56 if (!HasBufferedData() && !callback_.is_null()) {
57 base::ResetAndReturn(&callback_).Run(OK); 57 base::ResetAndReturn(&callback_).Run(OK);
58 } 58 }
59 } 59 }
60 60
61 QuicPriority QuicReliableClientStream::EffectivePriority() const { 61 QuicPriority QuicReliableClientStream::EffectivePriority() const {
62 if (delegate_ && delegate_->HasSendHeadersComplete()) { 62 if (delegate_ && delegate_->HasSendHeadersComplete()) {
63 return QuicDataStream::EffectivePriority(); 63 return QuicDataStream::EffectivePriority();
64 } 64 }
65 return QuicWriteBlockedList::kHighestPriority; 65 return QuicWriteBlockedList::kHighestPriority;
66 } 66 }
67 67
68 int QuicReliableClientStream::WriteStreamData( 68 int QuicReliableClientStream::WriteStreamData(
69 base::StringPiece data, 69 base::StringPiece data,
70 bool fin, 70 bool fin,
71 const CompletionCallback& callback) { 71 const CompletionCallback& callback) {
72 // We should not have data buffered. 72 // We should not have data buffered.
73 DCHECK(!HasBufferedData()); 73 DCHECK(!HasBufferedData());
74 // Writes the data, or buffers it. 74 // Writes the data, or buffers it.
75 WriteOrBufferData(data, fin, NULL); 75 WriteOrBufferData(data, fin, nullptr);
76 if (!HasBufferedData()) { 76 if (!HasBufferedData()) {
77 return OK; 77 return OK;
78 } 78 }
79 79
80 callback_ = callback; 80 callback_ = callback;
81 return ERR_IO_PENDING; 81 return ERR_IO_PENDING;
82 } 82 }
83 83
84 void QuicReliableClientStream::SetDelegate( 84 void QuicReliableClientStream::SetDelegate(
85 QuicReliableClientStream::Delegate* delegate) { 85 QuicReliableClientStream::Delegate* delegate) {
86 DCHECK((!delegate_ && delegate) || (delegate_ && !delegate)); 86 DCHECK((!delegate_ && delegate) || (delegate_ && !delegate));
87 delegate_ = delegate; 87 delegate_ = delegate;
88 } 88 }
89 89
90 void QuicReliableClientStream::OnError(int error) { 90 void QuicReliableClientStream::OnError(int error) {
91 if (delegate_) { 91 if (delegate_) {
92 QuicReliableClientStream::Delegate* delegate = delegate_; 92 QuicReliableClientStream::Delegate* delegate = delegate_;
93 delegate_ = NULL; 93 delegate_ = nullptr;
94 delegate->OnError(error); 94 delegate->OnError(error);
95 } 95 }
96 } 96 }
97 97
98 bool QuicReliableClientStream::CanWrite(const CompletionCallback& callback) { 98 bool QuicReliableClientStream::CanWrite(const CompletionCallback& callback) {
99 bool can_write = session()->connection()->CanWrite(HAS_RETRANSMITTABLE_DATA); 99 bool can_write = session()->connection()->CanWrite(HAS_RETRANSMITTABLE_DATA);
100 if (!can_write) { 100 if (!can_write) {
101 session()->MarkWriteBlocked(id(), EffectivePriority()); 101 session()->MarkWriteBlocked(id(), EffectivePriority());
102 DCHECK(callback_.is_null()); 102 DCHECK(callback_.is_null());
103 callback_ = callback; 103 callback_ = callback;
104 } 104 }
105 return can_write; 105 return can_write;
106 } 106 }
107 107
108 } // namespace net 108 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_protocol.cc ('k') | net/quic/quic_sent_packet_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698