Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 612293003: Fix ref cnt'ing issue in GrProgramElement. (Closed)

Created:
6 years, 2 months ago by bsalomon
Modified:
6 years, 2 months ago
Reviewers:
brian1, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix ref cnt'ing issue in GrProgramElement. Drop ref on GrGpuResources when GrProgramElement loses its last ref and already has a pending execution. BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/d012877a6d30ae768f9ccf3239ba09d730cbb6a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M include/gpu/GrProgramElement.h View 2 chunks +8 lines, -2 lines 0 comments Download
M src/gpu/GrProgramElement.cpp View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
brian1
6 years, 2 months ago (2014-10-02 22:29:33 UTC) #2
robertphillips
lgtm
6 years, 2 months ago (2014-10-03 12:23:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612293003/1
6 years, 2 months ago (2014-10-03 12:23:28 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 12:31:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as d012877a6d30ae768f9ccf3239ba09d730cbb6a5

Powered by Google App Engine
This is Rietveld 408576698