Issue 61213006: Revert 235728 "Removed RunUntilIdle between Stop and Close in UT..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 61213006: Revert 235728 "Removed RunUntilIdle between Stop and Close in UT..." (Closed)

Created:
7 years, 1 month ago by oshima

Modified:
7 years, 1 month ago

Reviewers:
mcasas

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 235728 "Removed RunUntilIdle between Stop and Close in UT..." > Removed RunUntilIdle between Stop and Close in UT, after Valgrind found a NULL addressing. > > Reland of: https://codereview.chromium.org/29423003/ > > Added video capture capabilities retrieval and caching to VideoCaptureManager. > > The local cache of video capture names and capabilities is created in a > codepath starting in EnumerateDevices. The cache is update during > StartCaptureForClient() and StopCaptureForClient(). > > Also added unittests (http://goo.gl/QQbpXW). > > BUG=309554, 319955 > TBR=perkj, ncarter, xians1 > > Review URL: https://codereview.chromium.org/74703002 TBR=mcasas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235781

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -325 lines)			Patch
M	trunk/src/content/browser/renderer_host/media/video_capture_controller.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/video_capture_controller.cc	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/video_capture_manager.h	View	6 chunks	+12 lines, -42 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/video_capture_manager.cc	View	10 chunks	+42 lines, -134 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/media/video_capture_manager_unittest.cc	View	3 chunks	+1 line, -97 lines	0 comments	Download
M	trunk/src/media/video/capture/fake_video_capture_device.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/src/media/video/capture/fake_video_capture_device.cc	View	3 chunks	+9 lines, -24 lines	0 comments	Download
M	trunk/src/media/video/capture/mac/video_capture_device_mac.mm	View	1 chunk	+2 lines, -9 lines	0 comments	Download
M	trunk/src/media/video/capture/video_capture_device.h	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	trunk/src/media/video/capture/video_capture_device.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r235781.