RELAND 29423003: Added video capture capabilities retrieval and caching to VideoCaptureManager

Removed RunUntilIdle between Stop and Close in UT, after Valgrind found a NULL addressing.

Reland of: https://codereview.chromium.org/29423003/

Added video capture capabilities retrieval and caching to VideoCaptureManager. 

The local cache of video capture names and capabilities is created in a
codepath starting in EnumerateDevices. The cache is update during 
StartCaptureForClient() and StopCaptureForClient(). 

Also added unittests (http://goo.gl/QQbpXW). 

BUG=309554, 319955
TBR=perkj, ncarter, xians1

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235728

[tommi (sloooow) - chröme, 2013-11-18 09:38:16]

drive-by nits for future changes to the code.

https://codereview.chromium.org/74703002/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/media/video_capture_manager.h (right):

https://codereview.chromium.org/74703002/diff/1/content/browser/renderer_host...
content/browser/renderer_host/media/video_capture_manager.h:106: typedef
std::vector<DeviceInfo> DevicesInfo;
nit: This should be DeviceInfos since the plural is applied to the whole name.
As is it reads as singular.
https://code.google.com/p/chromium/codesearch#search/&q=Infos
Alternatively it could be named DeviceInfoCache.

https://codereview.chromium.org/74703002/diff/1/media/video/capture/fake_vide...
File media/video/capture/fake_video_capture_device.cc (right):

https://codereview.chromium.org/74703002/diff/1/media/video/capture/fake_vide...
media/video/capture/fake_video_capture_device.cc:30: int
FakeVideoCaptureDevice::NumberOfFakeDevices(void) {
remove void

https://codereview.chromium.org/74703002/diff/1/media/video/capture/fake_vide...
media/video/capture/fake_video_capture_device.cc:38: for (int n = 0; n <
number_of_fake_devices_; n++) {
++n

https://codereview.chromium.org/74703002/diff/1/media/video/capture/fake_vide...
media/video/capture/fake_video_capture_device.cc:48: formats->clear();
don't do this.  If the array must be empty, do DCHECK(formats->empty()).

https://codereview.chromium.org/74703002/diff/1/media/video/capture/fake_vide...
media/video/capture/fake_video_capture_device.cc:49: VideoCaptureCapability
capture_format_640x480;
why not use the ctor that accepts width, height, color etc?

[commit-bot: I haz the power, 2013-11-18 09:39:20]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[tommi (sloooow) - chröme, 2013-11-18 09:39:52]

On 2013/11/18 09:39:20, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a lowly provisional committer, _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

rs lgtm.

[commit-bot: I haz the power, 2013-11-18 09:40:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mcasas@chromium.org/74703002/1

[commit-bot: I haz the power, 2013-11-18 12:59:42]

Change committed as 235728