Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 612063002: Expose IA and IA2 role and state for HTML input type attributes related to date and time. (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, dmazzoni, aboxhall, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Expose IA and IA2 role and state for HTML input type attributes related to date and time. For input type date, datetime and datetime-local, time, month, week - IA and IA2 role and states are not exposed properly. BUG=418486 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M Source/core/accessibility/AXNodeObject.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M Source/core/accessibility/AXObject.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/accessibility/AXRenderObject.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M public/web/WebAXEnums.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
shreeramk
Please review. Thanks!
6 years, 2 months ago (2014-09-29 13:01:35 UTC) #2
shreeramk
On 2014/09/29 13:01:35, shreeram.k wrote: > Please review. > > Thanks! I have added separate ...
6 years, 2 months ago (2014-09-29 13:49:17 UTC) #3
dmazzoni
lgtm
6 years, 2 months ago (2014-09-29 15:09:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/612063002/1
6 years, 2 months ago (2014-09-29 15:10:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 182848
6 years, 2 months ago (2014-09-29 15:53:05 UTC) #7
Zhenyao Mo
This likely broke DumpAccessibilityTreeTest.AccessibilityInputTime in content_browsertest Attempt to revert - if turns out unrelated, I'll ...
6 years, 2 months ago (2014-09-29 20:31:30 UTC) #8
Zhenyao Mo
6 years, 2 months ago (2014-09-29 20:32:02 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/609403005/ by zmo@chromium.org.

The reason for reverting is: This likely broke
DumpAccessibilityTreeTest.AccessibilityInputTime in
content_browsertest.

Powered by Google App Engine
This is Rietveld 408576698