Issue 609403005: Revert of Expose IA and IA2 role and state for HTML input type attributes related to date and time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 609403005: Revert of Expose IA and IA2 role and state for HTML input type attributes related to date and time. (Closed)

Created:
6 years, 2 months ago by Zhenyao Mo

Modified:
6 years, 2 months ago

Reviewers:
shreeramk, Peter Lundblad, aboxhall, dmazzoni

CC:
blink-reviews, jamesr, dglazkov+blink, dmazzoni, aboxhall, mkwst+moarreviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Revert of Expose IA and IA2 role and state for HTML input type attributes related to date and time. (patchset #1 id:1 of https://codereview.chromium.org/612063002/) Reason for revert: This likely broke DumpAccessibilityTreeTest.AccessibilityInputTime in content_browsertest Original issue's description: > Expose IA and IA2 role and state for HTML input type attributes related to date and time. > > For input type date, datetime and datetime-local, time, month, week - IA and IA2 role and states > are not exposed properly. > > BUG=418486 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182848 TBR=dmazzoni@chromium.org,aboxhall@chromium.org,plundblad@chromium.org,shreeram.k@samsung.com NOTREECHECKS=true NOTRY=true BUG=418486 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182863

Created: 6 years, 2 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -27 lines)			Patch
M	Source/core/accessibility/AXNodeObject.cpp	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	Source/core/accessibility/AXObject.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	Source/core/accessibility/AXRenderObject.cpp	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	Source/web/AssertMatchingEnums.cpp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	public/web/WebAXEnums.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Zhenyao Mo

Created Revert of Expose IA and IA2 role and state for HTML input type attributes ...

6 years, 2 months ago (2014-09-29 20:32:03 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609403005/1

6 years, 2 months ago (2014-09-29 20:32:51 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-09-29 20:34:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 182863