Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: Source/bindings/tests/idls/core/TestObject.idl

Issue 611953003: Canvas2D Performance: fix the bottleneck of hasInstance during JS binding -- overloading (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: update code accordingly (w/o redundant type check for overload resolution) Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/methods.cpp ('k') | Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/idls/core/TestObject.idl
diff --git a/Source/bindings/tests/idls/core/TestObject.idl b/Source/bindings/tests/idls/core/TestObject.idl
index 204d2e5e364e8a02f99343832f8aef23ea69d55a..46ff4ae1ce1927f9944603866af7f5a65452a439 100644
--- a/Source/bindings/tests/idls/core/TestObject.idl
+++ b/Source/bindings/tests/idls/core/TestObject.idl
@@ -525,6 +525,20 @@ interface TestObject {
[TypeChecking=Interface] void useToImpl4ArgumentsCheckingIfPossibleWithOptionalArg(Node node1, optional Node node2);
[TypeChecking=Interface] void useToImpl4ArgumentsCheckingIfPossibleWithNullableArg(Node node1, Node? node2);
[TypeChecking=Interface] void useToImpl4ArgumentsCheckingIfPossibleWithUndefinedArg(Node node1, [Default=Undefined] optional Node node2);
+ // Avoid redundant type checking -- overload resolution
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsA(Node a, long b);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsA(long a, long b);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsB(Node a);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsB(long a, long b);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsC(Node a);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsC(long a, optional long b);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsD(Node a, Node b);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsD(Node a, long b);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsE(Node a, Node b);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsE(Node a, optional long b);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsF(optional Node a);
+ [TypeChecking=Interface] void typeCheckingMaybeRedundantForOverloadingMethodsF(Document a, optional Node b);
+
[TypeChecking=Unrestricted] void typeCheckingUnrestrictedVoidMethodFloatArgDoubleArg(float floatArg, double doubleArg);
[Unforgeable] void unforgeableVoidMethod();
void voidMethodTestInterfaceGarbageCollectedSequenceArg(sequence<TestInterfaceGarbageCollected> testInterfaceGarbageCollectedSequenceArg);
« no previous file with comments | « Source/bindings/templates/methods.cpp ('k') | Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698