Source/bindings/templates/methods.cpp - Issue 611953003: Canvas2D Performance: fix the bottleneck of hasInstance during JS binding -- overloading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/methods.cpp

Issue 611953003: Canvas2D Performance: fix the bottleneck of hasInstance during JS binding -- overloading (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: update code accordingly (w/o redundant type check for overload resolution) Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/templates/methods.cpp

diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp

index 94b70730869b707916dfc76315938738c13565d4..c9622c0cdd785aef73778c8973ebbb3b7cfe2cb5 100644

--- a/Source/bindings/templates/methods.cpp

+++ b/Source/bindings/templates/methods.cpp

@@ -109,7 +109,8 @@ if (UNLIKELY(info.Length() <= {{argument.index}})) {

return;

}

{% endif %}

-{% if argument.has_type_checking_interface and not argument.is_variadic_wrapper_type %}

+{% if (argument.has_type_checking_interface and not argument.is_variadic_wrapper_type and

+ not argument.type_checked_already) %}

{# Type checking for wrapper interface types (if interface not implemented,

throw a TypeError), per http://www.w3.org/TR/WebIDL/#es-interface

Note: for variadic arguments, the type checking is done for each matched

« no previous file with comments | « Source/bindings/scripts/v8_methods.py ('k') | Source/bindings/tests/idls/core/TestObject.idl » ('j') | no next file with comments »