Source/bindings/scripts/v8_methods.py - Issue 611953003: Canvas2D Performance: fix the bottleneck of hasInstance during JS binding -- overloading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 611953003: Canvas2D Performance: fix the bottleneck of hasInstance during JS binding -- overloading (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: update auto-generated code for test cases I added, the change in JS binding is applied Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_methods.py

diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py

index 2fcb88633c3a5af04ddc72f54677fba89e3ac992..144266ad4a4ba11e281c30657bbd813b91dff610 100644

--- a/Source/bindings/scripts/v8_methods.py

+++ b/Source/bindings/scripts/v8_methods.py

@@ -236,6 +236,7 @@ def argument_context(interface, method, argument, index):

'v8_set_return_value_for_main_world': v8_set_return_value(interface.name, method, this_cpp_value, for_main_world=True),

'v8_value_to_local_cpp_value': v8_value_to_local_cpp_value(argument, index, return_promise=method.returns_promise),

'vector_type': v8_types.cpp_ptr_type('Vector', 'HeapVector', idl_type.gc_type),

+ 'type_checked_already': False,

Jens Widell 2014/10/10 10:14:53 Move this up a bit; the list should be sorted alph

yunchao 2014/10/10 11:40:48 Done.

}

« Source/bindings/scripts/v8_interface.py ('K') | « Source/bindings/scripts/v8_interface.py ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »