Canvas2D Performance: fix the bottleneck of hasInstance during JS binding -- overloading

Source/bindings/scripts/v8_interface.py

Index: Source/bindings/scripts/v8_interface.py
diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py
index 9cb32a59af27c5984346bf23bf7c82a820cc6830..836b249d6c6455af29f6c66b84ee42701232bd2a 100644
--- a/Source/bindings/scripts/v8_interface.py
+++ b/Source/bindings/scripts/v8_interface.py
@@ -753,6 +753,11 @@ def resolution_tests_methods(effective_overloads):
         test = 'V8{idl_type}::hasInstance({cpp_value}, info.GetIsolate())'.format(idl_type=idl_type.base_type, cpp_value=cpp_value)
         yield test, method
 
+    for argument, method in arguments_methods:

[Jens Widell, 2014/10/10 10:14:53]

Could you add a comment before this code explaining what we're doing, and
specifically under what circumstances it's safe/not safe to say "type already
checked"?

[yunchao, 2014/10/10 11:40:48]

Done.

+        if argument['idl_type_object'].is_wrapper_type and method['number_of_required_arguments'] == method['number_of_arguments']:

[Jens Widell, 2014/10/10 10:14:53]

You can use argument['is_wrapper_type'] here instead.

[yunchao, 2014/10/10 11:40:48]

Acknowledged.

+            argument['type_checked_already'] = True
+
+
     # 8. Otherwise: if V is any kind of object except for a native Date object,
     # a native RegExp object, and there is an entry in S that has one of the
     # following types at position i of its type list,
@@ -912,6 +917,7 @@ def constructor_context(interface, constructor):
         'is_raises_exception': is_constructor_raises_exception,
         'number_of_required_arguments':
             number_of_required_arguments(constructor),
+        'number_of_arguments': len(constructor.arguments),

[Jens Widell, 2014/10/10 10:14:53]

Move up a bit; the list should be sorted alphabetically.

[yunchao, 2014/10/10 11:40:48]

Done.

     }