Refactor SyncBackendHost

chrome/browser/sync/glue/sync_backend_host_unittest.cc

Index: chrome/browser/sync/glue/sync_backend_host_unittest.cc
diff --git a/chrome/browser/sync/glue/sync_backend_host_unittest.cc b/chrome/browser/sync/glue/sync_backend_host_unittest.cc
index 9ce675d762e6a8d5ff1f428fdf3d583cbbb3f35b..0558456e3dc29966e493101fb76e71cc6aa5b0bd 100644
--- a/chrome/browser/sync/glue/sync_backend_host_unittest.cc
+++ b/chrome/browser/sync/glue/sync_backend_host_unittest.cc
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/sync/glue/sync_backend_host.h"
-
 #include <cstddef>
 
 #include "base/location.h"
@@ -15,6 +13,8 @@
 #include "chrome/browser/invalidation/invalidator_storage.h"
 #include "chrome/browser/prefs/pref_service_syncable.h"
 #include "chrome/browser/sync/glue/device_info.h"
+#include "chrome/browser/sync/glue/sync_backend_host_impl.h"

[Nicolas Zea, 2013/11/06 18:03:21]

nit: move to be first #include?

[rlarocque, 2013/11/06 21:48:47]

The style checker complains.  I think it has an exception that allows foo.h to
be the first include in foo_unittest.cc.  Since the name changed, the exception
no longer applies.

I could rename this file to sync_backend_host_impl_unittest.cc then move it
back.  I was on the fence about doing that anyway.  I figured that since
SyncBackendHostImpl is the only "real" SyncBackendHost, it made sense to keep
calling its tests sync_backend_host_unittest.cc.  I could go either way, though.

[Nicolas Zea, 2013/11/06 22:18:25]

Ah, yeah, I'd prefer renaming to match the impl

[rlarocque, 2013/11/06 22:48:47]

Done.

+#include "chrome/browser/sync/glue/sync_frontend.h"
 #include "chrome/browser/sync/glue/synced_device_tracker.h"
 #include "chrome/browser/sync/sync_prefs.h"
 #include "chrome/test/base/testing_profile.h"
@@ -137,7 +137,7 @@ class SyncBackendHostTest : public testing::Test {
   virtual void SetUp() OVERRIDE {
     profile_.reset(new TestingProfile());
     sync_prefs_.reset(new SyncPrefs(profile_->GetPrefs()));
-    backend_.reset(new SyncBackendHost(
+    backend_.reset(new SyncBackendHostImpl(
         profile_->GetDebugName(),
         profile_.get(),
         sync_prefs_->AsWeakPtr()));