Refactor SyncBackendHost

chrome/browser/sync/glue/sync_backend_host_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/sync/glue/sync_backend_host.h"
-
 #include <cstddef>
 
 #include "base/location.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/test/test_timeouts.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/invalidation/invalidator_storage.h"
 #include "chrome/browser/prefs/pref_service_syncable.h"
 #include "chrome/browser/sync/glue/device_info.h"
+#include "chrome/browser/sync/glue/sync_backend_host_impl.h"

[Nicolas Zea, 2013/11/06 18:03:21]

nit: move to be first #include?

[rlarocque, 2013/11/06 21:48:47]

The style checker complains.  I think it has an exception that allows foo.h to
be the first include in foo_unittest.cc.  Since the name changed, the exception
no longer applies.

I could rename this file to sync_backend_host_impl_unittest.cc then move it
back.  I was on the fence about doing that anyway.  I figured that since
SyncBackendHostImpl is the only "real" SyncBackendHost, it made sense to keep
calling its tests sync_backend_host_unittest.cc.  I could go either way, though.

[Nicolas Zea, 2013/11/06 22:18:25]

Ah, yeah, I'd prefer renaming to match the impl

[rlarocque, 2013/11/06 22:48:47]

Done.

+#include "chrome/browser/sync/glue/sync_frontend.h"
 #include "chrome/browser/sync/glue/synced_device_tracker.h"
 #include "chrome/browser/sync/sync_prefs.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/user_prefs/pref_registry_syncable.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "content/public/test/test_utils.h"
 #include "google/cacheinvalidation/include/types.h"
 #include "net/url_request/test_url_fetcher_factory.h"
 #include "sync/internal_api/public/base/model_type.h"
@@ skipping 102 matching lines @@
  protected:
   SyncBackendHostTest()
       : thread_bundle_(content::TestBrowserThreadBundle::REAL_IO_THREAD),
         fake_manager_(NULL) {}
 
   virtual ~SyncBackendHostTest() {}
 
   virtual void SetUp() OVERRIDE {
     profile_.reset(new TestingProfile());
     sync_prefs_.reset(new SyncPrefs(profile_->GetPrefs()));
-    backend_.reset(new SyncBackendHost(
+    backend_.reset(new SyncBackendHostImpl(
         profile_->GetDebugName(),
         profile_.get(),
         sync_prefs_->AsWeakPtr()));
     credentials_.email = "user@example.com";
     credentials_.sync_token = "sync_token";
 
     fake_manager_factory_.reset(new FakeSyncManagerFactory(&fake_manager_));
 
     // These types are always implicitly enabled.
     enabled_types_.PutAll(syncer::ControlTypes());
@@ skipping 531 matching lines @@
   fake_manager_factory_->set_progress_marker_types(enabled_types_);
   fake_manager_factory_->set_initial_sync_ended_types(enabled_types_);
   InitializeBackend(true);
   EXPECT_EQ(syncer::CONFIGURE_REASON_NEWLY_ENABLED_DATA_TYPE,
             fake_manager_->GetAndResetConfigureReason());
 }
 
 }  // namespace
 
 }  // namespace browser_sync