Add 1.2GHz cpu clock support for T25

Add 1.2GHz cpu clock support for T25

Change-Id: Ibb5d6f80f5a0dc91984b1bbbf4117a229a48a8a4

CHROMIUM: ARM: tegra: Add cpu frequency table for T25.

BUG=None
TEST=Did unit test on both T20 and T25 seaboard.

Signed-off-by: Jimmy Zhang <jimmzhang@nvidia.com>;

[jimmzhang, 2011-01-12 00:32:50]

Changes made in code review is the first part of changes related to max cpu
clock rate change. The second part will be DVFS related tables update for
supporting new higher max rate. Since DVFS is still disabled in current build,
the changes in DVFS will be made when DVFS is enabled in ChromeOS build.

[Olof Johansson, 2011-01-12 01:05:28]

Hi,

Some comments below. Also, please prefix the first line with:

CHROMIUM: ARM: tegra: <Add 1.2...>

http://codereview.chromium.org/6116004/diff/1/arch/arm/mach-tegra/cpu-tegra.c
File arch/arm/mach-tegra/cpu-tegra.c (right):

http://codereview.chromium.org/6116004/diff/1/arch/arm/mach-tegra/cpu-tegra.c...
arch/arm/mach-tegra/cpu-tegra.c:216: freq_table_t20;
I would prefer to see this as a regular if/else.

http://codereview.chromium.org/6116004/diff/1/arch/arm/mach-tegra/tegra2_cloc...
File arch/arm/mach-tegra/tegra2_clocks.c (right):

http://codereview.chromium.org/6116004/diff/1/arch/arm/mach-tegra/tegra2_cloc...
arch/arm/mach-tegra/tegra2_clocks.c:792: 
Unrelated change, please discard

http://codereview.chromium.org/6116004/diff/1/arch/arm/mach-tegra/tegra2_cloc...
arch/arm/mach-tegra/tegra2_clocks.c:1574: .max_rate  = 1200000000,
Is it safe to set max_rate here? Shouldn't you update it dynamically when you
detect T25 instead? (same for the other changes below).

[jimmzhang, 2011-01-12 01:22:56]

http://codereview.chromium.org/6116004/diff/1/arch/arm/mach-tegra/cpu-tegra.c
File arch/arm/mach-tegra/cpu-tegra.c (right):

http://codereview.chromium.org/6116004/diff/1/arch/arm/mach-tegra/cpu-tegra.c...
arch/arm/mach-tegra/cpu-tegra.c:216: freq_table_t20;
On 2011/01/12 01:05:28, Olof Johansson wrote:
> I would prefer to see this as a regular if/else.

Sure, I can change it to that way.

http://codereview.chromium.org/6116004/diff/1/arch/arm/mach-tegra/tegra2_cloc...
File arch/arm/mach-tegra/tegra2_clocks.c (right):

http://codereview.chromium.org/6116004/diff/1/arch/arm/mach-tegra/tegra2_cloc...
arch/arm/mach-tegra/tegra2_clocks.c:792: 
On 2011/01/12 01:05:28, Olof Johansson wrote:
> Unrelated change, please discard

will be removed.

http://codereview.chromium.org/6116004/diff/1/arch/arm/mach-tegra/tegra2_cloc...
arch/arm/mach-tegra/tegra2_clocks.c:1574: .max_rate  = 1200000000,
On 2011/01/12 01:05:28, Olof Johansson wrote:
> Is it safe to set max_rate here? Shouldn't you update it dynamically when you
> detect T25 instead? (same for the other changes below).

The max value is still limited by the cpu frequency table. In case of T20, the
max rate will only be set to 1.0GHz.

[Olof Johansson, 2011-01-12 18:53:07]

http://codereview.chromium.org/6116004/diff/1/arch/arm/mach-tegra/tegra2_cloc...
File arch/arm/mach-tegra/tegra2_clocks.c (right):

http://codereview.chromium.org/6116004/diff/1/arch/arm/mach-tegra/tegra2_cloc...
arch/arm/mach-tegra/tegra2_clocks.c:1574: .max_rate  = 1200000000,
Ok, sounds good.

[jimmzhang, 2011-01-12 23:28:40]

Added additional code on this issue.

[Olof Johansson, 2011-01-12 23:33:09]

Thanks, applied.