Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 611593003: Clean up forward declarations in Source/core/html (Closed)

Created:
6 years, 2 months ago by rwlbuis
Modified:
6 years, 2 months ago
Reviewers:
haraken
CC:
blink-reviews, Yoav Weiss, philipj_slow, gavinp+prerender_chromium.org, Rik, webcomponents-bugzilla_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, aandrey+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up forward declarations in Source/core/html These forward references are not needed anymore. After this patch, Source/core/html has no unneeded forward references anymore. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -79 lines) Patch
M Source/core/html/FormAssociatedElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLDocument.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLFieldSetElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/html/HTMLImageElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMarqueeElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMeterElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLProgressElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLTextFormControlElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/CanvasPathMethods.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureATC.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureETC1.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLCompressedTextureS3TC.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLContextGroup.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/DateInputType.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/forms/FormController.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/InputType.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/forms/SearchInputType.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/forms/StepRange.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/ime/InputMethodContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/imports/HTMLImport.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/imports/HTMLImportTreeRoot.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/imports/HTMLImportsController.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/parser/BackgroundHTMLParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/parser/HTMLElementStack.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLScriptRunner.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/parser/TextResourceDecoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/XSSAuditor.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/shadow/MediaControls.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/MeterShadowElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/PickerIndicatorElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/SliderThumbElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/track/InbandTextTrack.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/track/TextTrackCue.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
rwlbuis
PTAL
6 years, 2 months ago (2014-09-26 21:24:45 UTC) #2
rwlbuis
Removing tkent due to high review load. Nice idea to indicate this.
6 years, 2 months ago (2014-09-26 21:26:23 UTC) #4
haraken
LGTM
6 years, 2 months ago (2014-09-27 01:19:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611593003/1
6 years, 2 months ago (2014-09-27 02:29:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611593003/1
6 years, 2 months ago (2014-09-29 01:45:34 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 09:27:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182814

Powered by Google App Engine
This is Rietveld 408576698