Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 611483002: Fix for crash when attaching a frame in WebUI renderer. (Closed)

Created:
6 years, 2 months ago by Krzysztof Olczyk
Modified:
6 years, 2 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, Mostyn Bramley-Moore, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix for crash when attaching a frame in WebUI renderer. It crashes when trying to install property on "chrome" object in Javascript. Before the patch, the code assumes the "chrome" either does not exist or is an object. Apparently, it holds "undefined" value in WebUI pages. BUG= Committed: https://crrev.com/e1b79c756bf3ee66a4211f06d59af0c95a17d49e Cr-Commit-Position: refs/heads/master@{#297621}

Patch Set 1 #

Total comments: 1

Patch Set 2 : As suggested, factored out the solution and used in other extensions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -21 lines) Patch
M content/browser/web_contents/web_contents_impl_browsertest.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/renderer/chrome_object_extensions_utils.h View 1 1 chunk +17 lines, -0 lines 0 comments Download
A content/renderer/chrome_object_extensions_utils.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download
M content/renderer/memory_benchmarking_extension.cc View 1 2 chunks +3 lines, -7 lines 0 comments Download
M content/renderer/skia_benchmarking_extension.cc View 1 2 chunks +3 lines, -7 lines 0 comments Download
M content/renderer/web_ui_extension.cc View 1 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Krzysztof Olczyk
Hi guys, could you please take a look at this fix for a CHECK() abort ...
6 years, 2 months ago (2014-09-26 13:51:01 UTC) #2
Avi (use Gerrit)
Please give a bug number in the description. I don't know about webui so I ...
6 years, 2 months ago (2014-09-26 15:09:28 UTC) #3
Mike West
Drive-by non-OWNER comments. This looks pretty reasonable: one request below. https://codereview.chromium.org/611483002/diff/1/content/renderer/web_ui_extension.cc File content/renderer/web_ui_extension.cc (right): https://codereview.chromium.org/611483002/diff/1/content/renderer/web_ui_extension.cc#newcode76 ...
6 years, 2 months ago (2014-09-30 07:51:47 UTC) #5
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-09-30 08:46:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611483002/20001
6 years, 2 months ago (2014-10-01 09:12:13 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 1f8f04f28ed6a1c96f114f5c709184879a0d410c
6 years, 2 months ago (2014-10-01 10:07:06 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 10:08:06 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1b79c756bf3ee66a4211f06d59af0c95a17d49e
Cr-Commit-Position: refs/heads/master@{#297621}

Powered by Google App Engine
This is Rietveld 408576698