Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9810)

Unified Diff: content/renderer/chrome_object_extensions_utils.cc

Issue 611483002: Fix for crash when attaching a frame in WebUI renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: As suggested, factored out the solution and used in other extensions. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/chrome_object_extensions_utils.cc
diff --git a/content/renderer/chrome_object_extensions_utils.cc b/content/renderer/chrome_object_extensions_utils.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b9c3cdebba2adbd845972f8e4d1198b22bd7c1eb
--- /dev/null
+++ b/content/renderer/chrome_object_extensions_utils.cc
@@ -0,0 +1,26 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/chrome_object_extensions_utils.h"
+
+#include "gin/converter.h"
+#include "v8/include/v8.h"
+
+namespace content {
+
+v8::Handle<v8::Object> GetOrCreateChromeObject(
+ v8::Isolate* isolate, v8::Handle<v8::Object> global) {
+ v8::Handle<v8::Object> chrome;
+ v8::Handle<v8::Value> chrome_value =
+ global->Get(gin::StringToV8(isolate, "chrome"));
+ if (chrome_value.IsEmpty() || !chrome_value->IsObject()) {
+ chrome = v8::Object::New(isolate);
+ global->Set(gin::StringToSymbol(isolate, "chrome"), chrome);
+ } else {
+ chrome = chrome_value->ToObject();
+ }
+ return chrome;
+}
+
+} // namespace content
« no previous file with comments | « content/renderer/chrome_object_extensions_utils.h ('k') | content/renderer/memory_benchmarking_extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698