components/password_manager/content/renderer/credential_manager_client.h - Issue 611383002: Replace OVERRIDE with its C++11 counterpart in components/password_manager/

Unified Diff: components/password_manager/content/renderer/credential_manager_client.h

Issue 611383002: Replace OVERRIDE with its C++11 counterpart in components/password_manager/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/password_manager_internals_service_factory.h ('k') | components/password_manager/content/renderer/credential_manager_client_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/renderer/credential_manager_client.h

diff --git a/components/password_manager/content/renderer/credential_manager_client.h b/components/password_manager/content/renderer/credential_manager_client.h

index c8a642f399f2e9404f3412c461684cc7122c4fd8..cd7b2cda2cb59547357e39ba5400ed163afe7df1 100644

--- a/components/password_manager/content/renderer/credential_manager_client.h

+++ b/components/password_manager/content/renderer/credential_manager_client.h

@@ -51,7 +51,7 @@ class CredentialManagerClient : public blink::WebCredentialManagerClient,

virtual ~CredentialManagerClient();

// RenderViewObserver:

- virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;

+ virtual bool OnMessageReceived(const IPC::Message& message) override;

// Message handlers for messages from the browser process:

virtual void OnAcknowledgeFailedSignIn(int request_id);

@@ -63,15 +63,15 @@ class CredentialManagerClient : public blink::WebCredentialManagerClient,

// blink::WebCredentialManager:

virtual void dispatchFailedSignIn(

const blink::WebCredential& credential,

- WebCredentialManagerClient::NotificationCallbacks* callbacks) OVERRIDE;

+ WebCredentialManagerClient::NotificationCallbacks* callbacks) override;

vabr (Chromium) 2014/09/30 14:39:14 Actually, methods from Blink should have no overri

Sunil Ratnu 2014/09/30 15:10:51 Oh! I did not know that. Made the changes as per y

virtual void dispatchSignedIn(

const blink::WebCredential& credential,

- WebCredentialManagerClient::NotificationCallbacks* callbacks) OVERRIDE;

- virtual void dispatchSignedOut(NotificationCallbacks* callbacks) OVERRIDE;

+ WebCredentialManagerClient::NotificationCallbacks* callbacks) override;

+ virtual void dispatchSignedOut(NotificationCallbacks* callbacks) override;

virtual void dispatchRequest(

bool zero_click_only,

const blink::WebVector<blink::WebURL>& federations,

- RequestCallbacks* callbacks) OVERRIDE;

+ RequestCallbacks* callbacks) override;

private:

typedef IDMap<blink::WebCredentialManagerClient::RequestCallbacks,