Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 61133002: Update bleed GM to contain HQ filtering test cases (Closed)

Created:
7 years, 1 month ago by bsalomon
Modified:
7 years, 1 month ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Update bleed GM to use HQ filtering. Committed: http://code.google.com/p/skia/source/detail?r=12188

Patch Set 1 #

Patch Set 2 : finish gm #

Patch Set 3 : revert incomplete changes to SkGpuDevice #

Patch Set 4 : Create bitmap with PM colors #

Patch Set 5 : cleanup #

Total comments: 4

Patch Set 6 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -69 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M gm/bleed.cpp View 1 2 3 4 5 10 chunks +114 lines, -69 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
7 years, 1 month ago (2013-11-08 03:57:51 UTC) #1
robertphillips
lgtm + 1 typo + 1 suggestion https://codereview.chromium.org/61133002/diff/90001/gm/bleed.cpp File gm/bleed.cpp (right): https://codereview.chromium.org/61133002/diff/90001/gm/bleed.cpp#newcode16 gm/bleed.cpp:16: Change to ...
7 years, 1 month ago (2013-11-08 13:01:05 UTC) #2
bsalomon
https://codereview.chromium.org/61133002/diff/90001/gm/bleed.cpp File gm/bleed.cpp (right): https://codereview.chromium.org/61133002/diff/90001/gm/bleed.cpp#newcode16 gm/bleed.cpp:16: On 2013/11/08 13:01:05, robertphillips wrote: > Change to "with ...
7 years, 1 month ago (2013-11-08 14:59:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/61133002/120001
7 years, 1 month ago (2013-11-08 15:00:03 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-08 15:09:25 UTC) #5
Message was sent while issue was closed.
Change committed as 12188

Powered by Google App Engine
This is Rietveld 408576698