Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 611083003: Instrumented libraries: fix NSS build. (Closed)

Created:
6 years, 2 months ago by earthdok
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Instrumented libraries: fix NSS build. Unset LDFLAGS before building. Otherwise we override the default LDFLAGS in the makefile, breaking the build. We want to append our flags to the default flags instead. BUG=418175 TBR=glider@chromium.org NOTRY=true Committed: https://crrev.com/aba96951daceed59306f501d6382b43ba87931c6 Cr-Commit-Position: refs/heads/master@{#297200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/instrumented_libraries/download_build_install.py View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
earthdok
6 years, 2 months ago (2014-09-29 17:31:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611083003/1
6 years, 2 months ago (2014-09-29 17:32:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 86f280415af842025b21fd3d049749c20b6f3ea6
6 years, 2 months ago (2014-09-29 17:32:46 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aba96951daceed59306f501d6382b43ba87931c6 Cr-Commit-Position: refs/heads/master@{#297200}
6 years, 2 months ago (2014-09-29 17:33:46 UTC) #5
Alexander Potapenko
6 years, 2 months ago (2014-09-30 11:25:06 UTC) #6
Message was sent while issue was closed.
rslgtm

Powered by Google App Engine
This is Rietveld 408576698