Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: third_party/instrumented_libraries/download_build_install.py

Issue 611083003: Instrumented libraries: fix NSS build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/instrumented_libraries/download_build_install.py
diff --git a/third_party/instrumented_libraries/download_build_install.py b/third_party/instrumented_libraries/download_build_install.py
index 3a2062de2be9fdc195c1e3f024d14b4b015f9f66..620d2dccb0aeba2f64ce7141ebd6bd17201db555 100755
--- a/third_party/instrumented_libraries/download_build_install.py
+++ b/third_party/instrumented_libraries/download_build_install.py
@@ -121,13 +121,16 @@ def nss_make_and_copy(parsed_arguments, environment, install_prefix):
make_args.append('CC="%s %s"' % (environment['CC'], environment['CFLAGS']))
make_args.append('CXX="%s %s"' %
(environment['CXX'], environment['CXXFLAGS']))
- # We need to override ZDEFS_FLAGS at least to prevent -Wl,-z,defs.
- # Might as well use this to pass the linker flags, since ZDEF_FLAGS is always
+ # We need to override ZDEFS_FLAG at least to prevent -Wl,-z,defs.
+ # Might as well use this to pass the linker flags, since ZDEF_FLAG is always
# added during linking on Linux.
make_args.append('ZDEFS_FLAG="-Wl,-z,nodefs %s"' % environment['LDFLAGS'])
make_args.append('NSPR_INCLUDE_DIR=/usr/include/nspr')
make_args.append('NSPR_LIB_DIR=%s/lib' % install_prefix)
make_args.append('NSS_ENABLE_ECC=1')
+ # Make sure we don't override the default flags.
+ for variable in ['CFLAGS', 'CXXFLAGS', 'LDFLAGS']:
+ del environment[variable]
with ScopedChangeDirectory('nss') as cd_nss:
# -j is not supported
shell_call('make %s' % ' '.join(make_args), parsed_arguments.verbose,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698