Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: tests/language/language_analyzer2.status

Issue 610863004: Start implementing checked mode compile time errors in analyzer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language/language_analyzer2.status
diff --git a/tests/language/language_analyzer2.status b/tests/language/language_analyzer2.status
index a6cc8f79d7a99dee527d5c8da4f9baea610d53e3..a1b9e531c1bcf79b6d457cdff6779cd181b3632b 100644
--- a/tests/language/language_analyzer2.status
+++ b/tests/language/language_analyzer2.status
@@ -426,15 +426,6 @@ void_type_test: StaticWarning
issue13474_test: StaticWarning, OK # Test Issue
-# Issue 16391. The analyzer handle compile-time error in checked only in these
-# cases:
-compile_time_constant_checked2_test/01: CompileTimeError # Language Issue 16391
-compile_time_constant_checked2_test/05: CompileTimeError # Language Issue 16391
-compile_time_constant_checked3_test/01: CompileTimeError # Language Issue 16391
-compile_time_constant_checked3_test/05: CompileTimeError # Language Issue 16391
-list_literal1_test/01: CompileTimeError # Issue 16391
-map_literal1_test/01: CompileTimeError # Issue 16391
-
# The following lines have been left in to quickly switch back to having deferred loading
# off by default again.
# Deferred loading support, tests marked as failing until support is enabled by default.
@@ -465,3 +456,14 @@ regress_12561_test: StaticWarning
main_not_a_function_test/01: Fail # http://dartbug.com/20030
main_test/03: Fail # http://dartbug.com/20030
no_main_test/01: Fail # http://dartbug.com/20030
+
+# Issue 16391. These tests are supposed to produce a compile time
+# error in checked mode, but they produce a compile time error
+# regardless of mode:
+[ $unchecked ]
+compile_time_constant_checked2_test/01: CompileTimeError # Language Issue 16391
+compile_time_constant_checked2_test/05: CompileTimeError # Language Issue 16391
+compile_time_constant_checked3_test/01: CompileTimeError # Language Issue 16391
+compile_time_constant_checked3_test/05: CompileTimeError # Language Issue 16391
+list_literal1_test/01: CompileTimeError # Issue 16391
+map_literal1_test/01: CompileTimeError # Issue 16391
kustermann 2014/09/29 16:11:28 I don't understand why there is a difference betwe
Paul Berry 2014/09/29 17:42:23 Sorry--I forgot to include the correct conditions

Powered by Google App Engine
This is Rietveld 408576698