Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4858)

Unified Diff: components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java

Issue 610673002: Expose startNetLog / stopNetLog from HttpUrlRequestFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java
diff --git a/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java b/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java
index e83bf37f9640b01ae7076d04dd6e165be73952b1..c90a7f222e804f7130ac797a27e0988c80cbaa03 100644
--- a/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java
+++ b/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java
@@ -45,4 +45,12 @@ class HttpUrlConnectionUrlRequestFactory extends HttpUrlRequestFactory {
return new HttpUrlConnectionUrlRequest(mContext, url, requestPriority,
headers, channel, listener);
}
+
+ @Override
+ public void startNetLogToFile(String fileName) {
mmenke 2014/09/29 18:53:19 Should we whine, or return false, or throw an exce
Charles 2014/09/29 19:09:41 No, because doing so would break the abstraction b
mef 2014/09/29 22:25:09 Done. Write 'not supported' message into net log f
+ }
+
+ @Override
+ public void stopNetLog() {
+ }
}

Powered by Google App Engine
This is Rietveld 408576698