Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java

Issue 610673002: Expose startNetLog / stopNetLog from HttpUrlRequestFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.net; 5 package org.chromium.net;
6 6
7 import android.content.Context; 7 import android.content.Context;
8 8
9 import java.nio.channels.WritableByteChannel; 9 import java.nio.channels.WritableByteChannel;
10 import java.util.Map; 10 import java.util.Map;
(...skipping 27 matching lines...) Expand all
38 headers, listener); 38 headers, listener);
39 } 39 }
40 40
41 @Override 41 @Override
42 public HttpUrlRequest createRequest(String url, int requestPriority, 42 public HttpUrlRequest createRequest(String url, int requestPriority,
43 Map<String, String> headers, WritableByteChannel channel, 43 Map<String, String> headers, WritableByteChannel channel,
44 HttpUrlRequestListener listener) { 44 HttpUrlRequestListener listener) {
45 return new HttpUrlConnectionUrlRequest(mContext, url, requestPriority, 45 return new HttpUrlConnectionUrlRequest(mContext, url, requestPriority,
46 headers, channel, listener); 46 headers, channel, listener);
47 } 47 }
48
49 @Override
50 public void startNetLogToFile(String fileName) {
mmenke 2014/09/29 18:53:19 Should we whine, or return false, or throw an exce
Charles 2014/09/29 19:09:41 No, because doing so would break the abstraction b
mef 2014/09/29 22:25:09 Done. Write 'not supported' message into net log f
51 }
52
53 @Override
54 public void stopNetLog() {
55 }
48 } 56 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698