Source/core/frame/FrameView.h - Issue 610423004: Preserve fractional scroll offset for JS scrolling API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameView.h

Issue 610423004: Preserve fractional scroll offset for JS scrolling API (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/FrameView.h

diff --git a/Source/core/frame/FrameView.h b/Source/core/frame/FrameView.h

index 5be2f8da53597fa90e5891d2e2daf9826639ab5d..46ac6c0436076d037dc1069f699bd468a57f0bd2 100644

--- a/Source/core/frame/FrameView.h

+++ b/Source/core/frame/FrameView.h

@@ -157,7 +157,7 @@ public:

virtual IntSize inputEventsOffsetForEmulation() const OVERRIDE;

void setInputEventsTransformForEmulation(const IntSize&, float);

- virtual void setScrollPosition(const IntPoint&, ScrollBehavior = ScrollBehaviorInstant) OVERRIDE;

+ virtual void setScrollPosition(const DoublePoint&, ScrollBehavior = ScrollBehaviorInstant) OVERRIDE;

virtual bool isRubberBandInProgress() const OVERRIDE;

void setScrollPositionNonProgrammatically(const IntPoint&);

« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/frame/FrameView.cpp » ('j') | Source/core/html/ImageDocument.cpp » ('J')