Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: Source/core/html/ImageDocument.cpp

Issue 610423004: Preserve fractional scroll offset for JS scrolling API (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: address comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/ImageDocument.cpp
diff --git a/Source/core/html/ImageDocument.cpp b/Source/core/html/ImageDocument.cpp
index f20e8d50eaffbd36cf4e5f78c6bed9eb545bdeee..569353cec8fc9a9b869ccdace1b0a44825905c3c 100644
--- a/Source/core/html/ImageDocument.cpp
+++ b/Source/core/html/ImageDocument.cpp
@@ -264,12 +264,12 @@ void ImageDocument::imageClicked(int x, int y)
updateLayout();
- float scale = this->scale();
+ double scale = this->scale();
- int scrollX = static_cast<int>(x / scale - (float)frame()->view()->width() / 2);
- int scrollY = static_cast<int>(y / scale - (float)frame()->view()->height() / 2);
+ double scrollX = x / scale - (double)frame()->view()->width() / 2;
eae 2014/10/08 16:19:36 Use c++ style static_cast please
Yufeng Shen (Slow to review) 2014/10/08 18:12:08 Done.
+ double scrollY = y / scale - (double)frame()->view()->height() / 2;
- frame()->view()->setScrollPosition(IntPoint(scrollX, scrollY));
+ frame()->view()->setScrollPosition(DoublePoint(scrollX, scrollY));
}
}

Powered by Google App Engine
This is Rietveld 408576698