Source/core/frame/LocalFrame.cpp - Issue 610423004: Preserve fractional scroll offset for JS scrolling API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalFrame.cpp

Issue 610423004: Preserve fractional scroll offset for JS scrolling API (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/scrolling/scrolling-apis-subpixel.html ('K') | « Source/core/frame/LocalDOMWindow.cpp ('k') | Source/core/frame/PinchViewport.cpp » ('j') | Source/core/html/ImageDocument.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/LocalFrame.cpp

diff --git a/Source/core/frame/LocalFrame.cpp b/Source/core/frame/LocalFrame.cpp

index 34698bdd1486c398a563d46c2803a8c97185bd94..c40f613f211c297dbed85ef36e8c468914b3f1b6 100644

--- a/Source/core/frame/LocalFrame.cpp

+++ b/Source/core/frame/LocalFrame.cpp

@@ -551,7 +551,7 @@ void LocalFrame::setPageAndTextZoomFactors(float pageZoomFactor, float textZoomF

// Update the scroll position when doing a full page zoom, so the content stays in relatively the same position.

LayoutPoint scrollPosition = view->scrollPosition();

float percentDifference = (pageZoomFactor / m_pageZoomFactor);

- view->setScrollPosition(IntPoint(scrollPosition.x() * percentDifference, scrollPosition.y() * percentDifference));

+ view->setScrollPosition(DoublePoint(scrollPosition.x() * percentDifference, scrollPosition.y() * percentDifference));

}