Source/core/html/ImageDocument.cpp - Issue 610423004: Preserve fractional scroll offset for JS scrolling API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/ImageDocument.cpp

Issue 610423004: Preserve fractional scroll offset for JS scrolling API (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/scrolling/scrolling-apis-subpixel.html ('K') | « Source/core/html/HTMLBodyElement.cpp ('k') | Source/core/rendering/RenderBox.h » ('j') | Source/core/rendering/RenderBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/ImageDocument.cpp

diff --git a/Source/core/html/ImageDocument.cpp b/Source/core/html/ImageDocument.cpp

index f20e8d50eaffbd36cf4e5f78c6bed9eb545bdeee..d6819243d892548da29708a5c14a54c581edb19c 100644

--- a/Source/core/html/ImageDocument.cpp

+++ b/Source/core/html/ImageDocument.cpp

@@ -266,10 +266,10 @@ void ImageDocument::imageClicked(int x, int y)

float scale = this->scale();

- int scrollX = static_cast<int>(x / scale - (float)frame()->view()->width() / 2);

- int scrollY = static_cast<int>(y / scale - (float)frame()->view()->height() / 2);

+ double scrollX = x / scale - (float)frame()->view()->width() / 2;

Rick Byers 2014/10/02 21:44:05 use (double) instead of (float) to prevent loss of

Yufeng Shen (Slow to review) 2014/10/02 23:34:34 Done.

+ double scrollY = y / scale - (float)frame()->view()->height() / 2;

- frame()->view()->setScrollPosition(IntPoint(scrollX, scrollY));

+ frame()->view()->setScrollPosition(DoublePoint(scrollX, scrollY));

}