Source/core/dom/Element.cpp - Issue 610423004: Preserve fractional scroll offset for JS scrolling API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.cpp

Issue 610423004: Preserve fractional scroll offset for JS scrolling API (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/scrolling/scrolling-apis-subpixel.html ('K') | « LayoutTests/fast/scrolling/scrolling-apis-subpixel-expected.txt ('k') | Source/core/frame/FrameView.h » ('j') | Source/core/html/ImageDocument.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index 6fe332d9b542020cbfff2fe2f868bc1fc7651c17..3fbc3c43508309278c1bade06826703856a2de2e 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -679,7 +679,7 @@ void Element::setScrollLeft(double newLeft)

if (!view)

return;

- view->setScrollPosition(IntPoint(roundf(newLeft * frame->pageZoomFactor()), view->scrollY()));

+ view->setScrollPosition(DoublePoint(newLeft * frame->pageZoomFactor(), view->scrollY()));

}

@@ -725,7 +725,7 @@ void Element::setScrollTop(double newTop)

if (!view)

return;

- view->setScrollPosition(IntPoint(view->scrollX(), roundf(newTop * frame->pageZoomFactor())));

+ view->setScrollPosition(DoublePoint(view->scrollX(), newTop * frame->pageZoomFactor()));

}